netdev - Re: [PATCH ethtool v3 3/4] ethtool: Rename QSFP-DD identifiers to use CMIS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ffa6379-e7f9-34b9-7504-b1ce21a160e0@nvidia.com>
Date:   Tue, 15 Jun 2021 19:12:53 +0300
From:   Moshe Shemesh <moshe@...dia.com>
To:     Ido Schimmel <idosch@...sch.org>
CC:     Michal Kubecek <mkubecek@...e.cz>, Andrew Lunn <andrew@...n.ch>,
        "Jakub Kicinski" <kuba@...nel.org>,
        Don Bollinger <don@...bollingers.org>,
        <netdev@...r.kernel.org>,
        Vladyslav Tarasiuk <vladyslavt@...dia.com>
Subject: Re: [PATCH ethtool v3 3/4] ethtool: Rename QSFP-DD identifiers to use
 CMIS


On 6/13/2021 5:20 PM, Ido Schimmel wrote:
> External email: Use caution opening links or attachments
>
>
> On Tue, Jun 08, 2021 at 01:32:27PM +0300, Moshe Shemesh wrote:
>> +void cmis_show_all(const struct ethtool_module_eeprom *page_zero,
>> +                const struct ethtool_module_eeprom *page_one)
>> +{
>> +     const __u8 *page_zero_data = page_zero->data;
>> +
>> +     cmis_show_identifier(page_zero_data);
>> +     cmis_show_power_info(page_zero_data);
>> +     cmis_show_connector(page_zero_data);
>> +     cmis_show_cbl_asm_len(page_zero_data);
>> +     cmis_show_sig_integrity(page_zero_data);
>> +     cmis_show_mit_compliance(page_zero_data);
>> +     cmis_show_mod_lvl_monitors(page_zero_data);
>> +
>> +     if (page_one)
>> +             cmis_show_link_len_from_page(page_one->data - 0x80);
>> +
>> +     cmis_show_vendor_info(page_zero_data);
>> +     cmis_show_rev_compliance(page_zero_data);
>> +}
>> diff --git a/cmis.h b/cmis.h
>> new file mode 100644
>> index 0000000..5b7ac38
>> --- /dev/null
>> +++ b/cmis.h
>> @@ -0,0 +1,128 @@
> [...]
>
>> +void cmis4_show_all(const struct ethtool_module_eeprom *page_zero,
>> +                 const struct ethtool_module_eeprom *page_one);
> Should be cmis_show_all():


I will fix and resend, thanks!

>
> netlink/module-eeprom.c:335:17: warning: implicit declaration of function ‘cmis_show_all’; did you mean ‘cmis4_show_all’? [-Wimplicit-function-declaration]
>    335 |                 cmis_show_all(page_zero, page_one);
>        |                 ^~~~~~~~~~~~~
>        |                 cmis4_show_all