netdev - Re: [PATCH net] rtnetlink: Fix regression in bridge VLAN configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zgvroy55.fsf@gmail.com>
Date:   Tue, 15 Jun 2021 19:06:46 +0200
From:   Joachim Wiberg <troglobit@...il.com>
To:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, nikolay@...dia.com,
        roopa@...dia.com, jiapeng.chong@...ux.alibaba.com,
        mlxsw@...dia.com, Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net] rtnetlink: Fix regression in bridge VLAN configuration

On Wed, Jun 09, 2021 at 14:17, Ido Schimmel <idosch@...sch.org> wrote:
> Cited commit started returning errors when notification info is not
> filled by the bridge driver, resulting in the following regression:
>
>  # ip link add name br1 type bridge vlan_filtering 1
>  # bridge vlan add dev br1 vid 555 self pvid untagged
>  RTNETLINK answers: Invalid argument
>
> As long as the bridge driver does not fill notification info for the
> bridge device itself, an empty notification should not be considered as
> an error. This is explained in commit 59ccaaaa49b5 ("bridge: dont send
> notification when skb->len == 0 in rtnl_bridge_notify").
>
> Fix by removing the error and add a comment to avoid future bugs.
>
> Fixes: a8db57c1d285 ("rtnetlink: Fix missing error code in rtnl_bridge_notify()")
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> Reviewed-by: Nikolay Aleksandrov <nikolay@...dia.com>

Fix does indeed solve the same problem I encountered myself yesterday,
and bisected today.  Tested successfully on a bridge setup with Marvell
88E6097 (DSA switch) for bridge offloading (not that it matters for this
particular fix).

Tested-by: Joachim Wiberg <troglobit@...il.com>

Best regards
 /Joachim