netdev - RE: [PATCH net-next] net: ice: ptp: fix compilation warning if PTP_1588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94536f439c894854b5109e77e830729c@intel.com>
Date:   Tue, 15 Jun 2021 19:10:20 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "lorenzo.bianconi@...hat.com" <lorenzo.bianconi@...hat.com>
Subject: RE: [PATCH net-next] net: ice: ptp: fix compilation warning if
 PTP_1588_CLOCK is disabled



> -----Original Message-----
> From: Lorenzo Bianconi <lorenzo@...nel.org>
> Sent: Tuesday, June 15, 2021 7:14 AM
> To: netdev@...r.kernel.org
> Cc: lorenzo.bianconi@...hat.com; Keller, Jacob E <jacob.e.keller@...el.com>
> Subject: [PATCH net-next] net: ice: ptp: fix compilation warning if
> PTP_1588_CLOCK is disabled
> 
> Fix the following compilation warning if PTP_1588_CLOCK is not enabled
> 
> drivers/net/ethernet/intel/ice/ice_ptp.h:149:1:
>    error: return type defaults to ‘int’ [-Werror=return-type]
>    ice_ptp_request_ts(struct ice_ptp_tx *tx, struct sk_buff *skb)
> 
> Fixes: ea9b847cda647 ("ice: enable transmit timestamps for E810 devices")
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>


Hah. Thanks. This is obviously correct.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> ---
>  drivers/net/ethernet/intel/ice/ice_ptp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.h
> b/drivers/net/ethernet/intel/ice/ice_ptp.h
> index 41e14f98f0e6..d01507eba036 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp.h
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp.h
> @@ -145,7 +145,7 @@ static inline int ice_get_ptp_clock_index(struct ice_pf *pf)
>  	return -1;
>  }
> 
> -static inline
> +static inline s8
>  ice_ptp_request_ts(struct ice_ptp_tx *tx, struct sk_buff *skb)
>  {
>  	return -1;
> --
> 2.31.1