netdev - Re: [PATCH] net: cdc_eem: fix tx fixup skb leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YMoTSAHnSpmpen6l@kroah.com>
Date:   Wed, 16 Jun 2021 17:05:44 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Linyu Yuan <linyyuan@...eaurora.org>
Cc:     Oliver Neukum <oliver@...kum.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: cdc_eem: fix tx fixup skb leak

On Wed, Jun 16, 2021 at 10:40:44PM +0800, Linyu Yuan wrote:
> when usbnet transmit a skb, eem fixup it in eem_tx_fixup(),
> if skb_copy_expand() failed, it return NULL,
> usbnet_start_xmit() will have no chance to free original skb.
> 
> fix it by free orginal skb in eem_tx_fixup() first,
> then check skb clone status, if failed, return NULL to usbnet.
> 
> Signed-off-by: Linyu Yuan <linyyuan@...eaurora.org>
> ---
>  drivers/net/usb/cdc_eem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What commit does this "Fix:"?  Can you please add that to the
signed-off-by area?

thanks,

greg k-h