netdev - Re: [PATCH ipsec] xfrm: Fix error reporting in xfrm_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210616062942.GG40979@gauss3.secunet.de>
Date:   Wed, 16 Jun 2021 08:29:42 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     <netdev@...r.kernel.org>
Subject: Re: [PATCH ipsec] xfrm: Fix error reporting in xfrm_state_construct.

On Mon, Jun 07, 2021 at 03:21:49PM +0200, Steffen Klassert wrote:
> When memory allocation for XFRMA_ENCAP or XFRMA_COADDR fails,
> the error will not be reported because the -ENOMEM assignment
> to the err variable is overwritten before. Fix this by moving
> these two in front of the function so that memory allocation
> failures will be reported.
> 
> Reported-by: Tobias Brunner <tobias@...ongswan.org>
> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
> ---

Now applied to the ipsec tree.