netdev - Re: [PATCH net-next 4/8] net: phy: fixed formatting issues with braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee9cae196cdd40fdaab80ef3d386e2ac@huawei.com>
Date:   Wed, 16 Jun 2021 06:39:47 +0000
From:   liweihang <liweihang@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        liangwenpeng <liangwenpeng@...wei.com>
Subject: Re: [PATCH net-next 4/8] net: phy: fixed formatting issues with
 braces

On 2021/6/11 22:41, Andrew Lunn wrote:
>> -	if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) {
>> +	if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
>>  		delay = MII_M1111_RGMII_RX_DELAY | MII_M1111_RGMII_TX_DELAY;
>> -	} else if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID) {
>> +	else if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID)
>>  		delay = MII_M1111_RGMII_RX_DELAY;
>> -	} else if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID) {
>> +	else if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID)
>>  		delay = MII_M1111_RGMII_TX_DELAY;
>> -	} else {
>> +	else
>>  		delay = 0;
>> -	}
> 
> Or turn it into a switch statement?
> 
>    Andrew
> 

Sure, I will put them into another patch.

Weihang