netdev - RE: [PATCH] net: iosm: remove the repeated declaration and comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2735788e3a224cb0b50fc015a76f4f82@intel.com>
Date:   Wed, 16 Jun 2021 07:51:23 +0000
From:   "Kumar, M Chetan" <m.chetan.kumar@...el.com>
To:     Shaokun Zhang <zhangshaokun@...ilicon.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     linuxwwan <linuxwwan@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: RE: [PATCH] net: iosm: remove the repeated declaration and comment

> Function 'ipc_mmio_get_cp_version' is declared twice, so remove the
> repeated declaration and wrong comments.
> 
> Cc: M Chetan Kumar <m.chetan.kumar@...el.com>
> Cc: Intel Corporation <linuxwwan@...el.com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@...ilicon.com>
> ---
>  drivers/net/wwan/iosm/iosm_ipc_mmio.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_mmio.h
> b/drivers/net/wwan/iosm/iosm_ipc_mmio.h
> index bcf77aea06e7..45e6923da78f 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_mmio.h
> +++ b/drivers/net/wwan/iosm/iosm_ipc_mmio.h
> @@ -121,16 +121,6 @@ void ipc_mmio_set_contex_info_addr(struct
> iosm_mmio *ipc_mmio,
>  				   phys_addr_t addr);
> 
>  /**
> - * ipc_mmio_get_cp_version - Write context info and AP memory range
> addresses.
> - *			     This needs to be called when CP is in
> - *			     IPC_MEM_DEVICE_IPC_INIT state
> - * @ipc_mmio:	Pointer to mmio instance
> - *
> - * Returns: cp version else failure value on error
> - */
> -int ipc_mmio_get_cp_version(struct iosm_mmio *ipc_mmio);
> -
> -/**
>   * ipc_mmio_get_cp_version - Get the CP IPC version
>   * @ipc_mmio:	Pointer to mmio instance
>   *
> --
> 2.7.4

Thanks,
Reviewed-by: M Chetan Kumar <m.chetan.kumar@...el.com>