netdev - Re: Hangs during tls multi_chunk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210617142234.272cc686@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 17 Jun 2021 14:22:34 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Seth Forshee <seth.forshee@...onical.com>
Cc:     Pooja Trivedi <pooja.trivedi@...ckpath.com>,
        Mallesham Jatharkonda <mallesham.jatharkonda@...convergence.com>,
        Josh Tway <josh.tway@...ckpath.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: Hangs during tls multi_chunk_sendfile selftest

On Thu, 17 Jun 2021 14:46:11 -0500 Seth Forshee wrote:
> I've observed that the tls multi_chunk_sendfile selftest hangs during
> recv() and ultimately times out, and it seems to have done so even when
> the test was first introduced. 

It hangs yet it passes? I lost track of this issue because the test
does pass on my system:

# PASSED: 183 / 183 tests passed.
# Totals: pass:183 fail:0 xfail:0 xpass:0 skip:0 error:0

$ uname -r
5.12.9-300.fc34.x86_64

> Reading through the commit message when
> it was added (0e6fbe39bdf7 "net/tls(TLS_SW): Add selftest for 'chunked'
> sendfile test") I get the impression that the test is meant to
> demonstrate a problem with ktls, but there's no indication that the
> problem has been fixed.

Yeah, the fix was discussed here:

https://lore.kernel.org/netdev/1591392508-14592-1-git-send-email-pooja.trivedi@stackpath.com/

IDK why it stalled to be honest :S

> Am I right that the expectation is that this test will fail? If that's
> the case, shouldn't this test be removed until the problem is fixed?