netdev - Re: [PATCH net-next v7 1/3] net: flow_dissector: extend bpf flow dissector support with vnet hdr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202106171530.R0zTpItc-lkp@intel.com>
Date:   Thu, 17 Jun 2021 15:43:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Tanner Love <tannerlove.kernel@...il.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Petar Penkov <ppenkov@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "Michael S . Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH net-next v7 1/3] net: flow_dissector: extend bpf flow
 dissector support with vnet hdr

Hi Tanner,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Tanner-Love/virtio_net-add-optional-flow-dissection-in-virtio_net_hdr_to_skb/20210617-082208
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 0c33795231bff5df410bd405b569c66851e92d4b
config: m68k-randconfig-r023-20210617 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b03a1eb684b925a09ae011d0e620d98ebf3b0abd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Tanner-Love/virtio_net-add-optional-flow-dissection-in-virtio_net_hdr_to_skb/20210617-082208
        git checkout b03a1eb684b925a09ae011d0e620d98ebf3b0abd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   net/core/filter.c: In function 'bpf_flow_keys_is_valid_access':
>> net/core/filter.c:7900:15: error: implicit declaration of function 'bpf_get_btf_vmlinux' [-Werror=implicit-function-declaration]
    7900 |   info->btf = bpf_get_btf_vmlinux();
         |               ^~~~~~~~~~~~~~~~~~~
>> net/core/filter.c:7900:13: warning: assignment to 'struct btf *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    7900 |   info->btf = bpf_get_btf_vmlinux();
         |             ^
   cc1: some warnings being treated as errors


vim +/bpf_get_btf_vmlinux +7900 net/core/filter.c

  7884	
  7885	int bpf_flow_keys_is_valid_access(int off, int size, enum bpf_access_type t,
  7886					  struct bpf_insn_access_aux *info)
  7887	{
  7888		if (off < 0 ||
  7889		    (u64)off + size > offsetofend(struct bpf_flow_keys, vhdr))
  7890			return -EACCES;
  7891	
  7892		switch (off) {
  7893		case bpf_ctx_range_ptr(struct bpf_flow_keys, vhdr):
  7894			if (t == BPF_WRITE || off % size != 0 || size != sizeof(__u64))
  7895				return -EACCES;
  7896	
  7897			if (!bpf_flow_dissector_btf_ids[0])
  7898				return -EINVAL;
  7899	
> 7900			info->btf = bpf_get_btf_vmlinux();
  7901			info->reg_type = PTR_TO_BTF_ID_OR_NULL;
  7902			info->btf_id = bpf_flow_dissector_btf_ids[0];
  7903	
  7904			break;
  7905		}
  7906	
  7907		return 0;
  7908	}
  7909	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (26985 bytes)