netdev - Re: [PATCH net-next v2 3/3] net: wwan: Allow WWAN drivers to provide blocking tx and poll function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Jun 2021 20:45:28 +0800
From:   kernel test robot <lkp@...el.com>
To:     Stephan Gerhold <stephan@...hold.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        netdev@...r.kernel.org, Loic Poulain <loic.poulain@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Aleksander Morgado <aleksander@...ksander.es>,
        Sergey Ryazanov <ryazanov.s.a@...il.com>,
        Johannes Berg <johannes.berg@...el.com>,
        Leon Romanovsky <leon@...nel.org>,
        M Chetan Kumar <m.chetan.kumar@...el.com>
Subject: Re: [PATCH net-next v2 3/3] net: wwan: Allow WWAN drivers to provide
 blocking tx and poll function

Hi Stephan,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Stephan-Gerhold/net-wwan-Add-RPMSG-WWAN-CTRL-driver/20210618-155527
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8fe088bd4fd12f4c8899b51d5bc3daad98767d49
config: arm-randconfig-r024-20210618 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/3e8b96e21bab08cfd3136fb7348c4cb77815e969
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Stephan-Gerhold/net-wwan-Add-RPMSG-WWAN-CTRL-driver/20210618-155527
        git checkout 3e8b96e21bab08cfd3136fb7348c4cb77815e969
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/usb/class/cdc-wdm.c:917:8: error: incompatible function pointer types initializing 'int (*)(struct wwan_port *, struct sk_buff *, bool)' (aka 'int (*)(struct wwan_port *, struct sk_buff *, _Bool)') with an expression of type 'int (struct wwan_port *, struct sk_buff *)' [-Werror,-Wincompatible-function-pointer-types]
           .tx = wdm_wwan_port_tx,
                 ^~~~~~~~~~~~~~~~
   1 error generated.


vim +917 drivers/usb/class/cdc-wdm.c

cac6fb015f7191 Loic Poulain 2021-05-11  913  
cac6fb015f7191 Loic Poulain 2021-05-11  914  static struct wwan_port_ops wdm_wwan_port_ops = {
cac6fb015f7191 Loic Poulain 2021-05-11  915  	.start = wdm_wwan_port_start,
cac6fb015f7191 Loic Poulain 2021-05-11  916  	.stop = wdm_wwan_port_stop,
cac6fb015f7191 Loic Poulain 2021-05-11 @917  	.tx = wdm_wwan_port_tx,
cac6fb015f7191 Loic Poulain 2021-05-11  918  };
cac6fb015f7191 Loic Poulain 2021-05-11  919  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (33309 bytes)