netdev - Re: [PATCH bpf v2] bpf: fix libelf endian handling in resolv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <162402900350.14256.7811206211874890348.git-patchwork-notify@kernel.org>
Date:   Fri, 18 Jun 2021 15:10:03 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Tony Ambardar <tony.ambardar@...il.com>
Cc:     daniel@...earbox.net, ast@...nel.org, andrii@...nel.org,
        Tony.Ambardar@...il.com, bpf@...r.kernel.org,
        netdev@...r.kernel.org, linux-mips@...r.kernel.org,
        stable@...r.kernel.org, fche@...hat.com, mark@...mp.org,
        jolsa@...nel.org, yhs@...com, jolsa@...hat.com
Subject: Re: [PATCH bpf v2] bpf: fix libelf endian handling in resolv_btfids

Hello:

This patch was applied to bpf/bpf.git (refs/heads/master):

On Thu, 17 Jun 2021 23:14:04 -0700 you wrote:
> The vmlinux ".BTF_ids" ELF section is declared in btf_ids.h to hold a list
> of zero-filled BTF IDs, which is then patched at link-time with correct
> values by resolv_btfids. The section is flagged as "allocable" to preclude
> compression, but notably the section contents (BTF IDs) are untyped.
> 
> When patching the BTF IDs, resolve_btfids writes in host-native endianness
> and relies on libelf for any required translation on reading and updating
> vmlinux. However, since the type of the .BTF_ids section content defaults
> to ELF_T_BYTE (i.e. unsigned char), no translation occurs. This results in
> incorrect patched values when cross-compiling to non-native endianness,
> and can manifest as kernel Oops and test failures which are difficult to
> troubleshoot [1].
> 
> [...]

Here is the summary with links:
  - [bpf,v2] bpf: fix libelf endian handling in resolv_btfids
    https://git.kernel.org/bpf/bpf/c/61e8aeda9398

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html