netdev - Re: [PATCH v2 iproute2] utils: bump max args number to 512 for batch files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9a44aba-74c1-50f6-5eb7-d5eb6f18a464@gmail.com>
Date:   Thu, 17 Jun 2021 20:57:55 -0600
From:   David Ahern <dsahern@...il.com>
To:     Guillaume Nault <gnault@...hat.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2 iproute2] utils: bump max args number to 512 for batch
 files

On 6/11/21 3:46 AM, Guillaume Nault wrote:
> Large tc filters can have many arguments. For example the following
> filter matches the first 7 MPLS LSEs, pops all of them, then updates
> the Ethernet header and redirects the resulting packet to eth1.
> 
> filter add dev eth0 ingress handle 44 priority 100 \
>   protocol mpls_uc flower mpls                     \
>     lse depth 1 label 1040076 tc 4 bos 0 ttl 175   \
>     lse depth 2 label 89648 tc 2 bos 0 ttl 9       \
>     lse depth 3 label 63417 tc 5 bos 0 ttl 185     \
>     lse depth 4 label 593135 tc 5 bos 0 ttl 67     \
>     lse depth 5 label 857021 tc 0 bos 0 ttl 181    \
>     lse depth 6 label 239239 tc 1 bos 0 ttl 254    \
>     lse depth 7 label 30 tc 7 bos 1 ttl 237        \
>   action mpls pop protocol mpls_uc pipe            \
>   action mpls pop protocol mpls_uc pipe            \
>   action mpls pop protocol mpls_uc pipe            \
>   action mpls pop protocol mpls_uc pipe            \
>   action mpls pop protocol mpls_uc pipe            \
>   action mpls pop protocol mpls_uc pipe            \
>   action mpls pop protocol ipv6 pipe               \
>   action vlan pop_eth pipe                         \
>   action vlan push_eth                             \
>     dst_mac 00:00:5e:00:53:7e                      \
>     src_mac 00:00:5e:00:53:03 pipe                 \
>   action mirred egress redirect dev eth1
> 
> This filter has 149 arguments, so it can't be used with tc -batch
> which is limited to a 100.
> 
> Let's bump the limit to 512. That should leave a lot of room for big
> batch commands.
> 
> v2:
>    -Define the limit in utils.h (Stephen Hemminger)
>    -Bump the limit even higher (256 -> 512) (Stephen Hemminger)
> 
> Signed-off-by: Guillaume Nault <gnault@...hat.com>
> ---
>  include/utils.h | 3 +++
>  lib/utils.c     | 4 ++--
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 

applied to iproute2-next. Thanks,