netdev - Re: [PATCH] selftests/tls: don't change cipher type in bidirectional test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YM0YYNrkihtExlTR@ubuntu-x1>
Date:   Fri, 18 Jun 2021 17:04:16 -0500
From:   Seth Forshee <seth.forshee@...onical.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Shuah Khan <shuah@...nel.org>, netdev@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests/tls: don't change cipher type in bidirectional
 test

On Fri, Jun 18, 2021 at 02:41:49PM -0700, Jakub Kicinski wrote:
> On Fri, 18 Jun 2021 15:45:32 -0500 Seth Forshee wrote:
> > The bidirectional test attempts to change the cipher to
> > TLS_CIPHER_AES_GCM_128. The test fixture setup will have already set
> > the cipher to be tested, and if it was different than the one set by
> > the bidir test setsockopt() will fail on account of having different
> > ciphers for rx and tx, causing the test to fail.
> 
> It's setting it up in the opposite direction, TLS is uni-directional.
> I've posted this earlier:

Ah, so it is, I missed that detail.

> https://patchwork.kernel.org/project/netdevbpf/patch/20210618202504.1435179-2-kuba@kernel.org/
> 
> Sorry for not CCing you.

No worries.

Thanks,
Seth