netdev - [PATCHv2] cxgb4: fix wrong shift.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210618092948.GA19615@duo.ucw.cz>
Date:   Fri, 18 Jun 2021 11:29:48 +0200
From:   Pavel Machek <pavel@...x.de>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     kernel list <linux-kernel@...r.kernel.org>,
        Colin Ian King <colin.king@...onical.com>,
        Raju Rangoju <rajur@...lsio.com>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        stable@...r.kernel.org
Subject: [PATCHv2] cxgb4: fix wrong shift.

While fixing coverity warning, commit dd2c79677375 introduced typo in
shift value. Fix that.
    
Signed-off-by: Pavel Machek (CIP) <pavel@...x.de>
Fixes: dd2c79677375 ("cxgb4: Fix unintentional sign extension issues")

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
index 22c9ac922eba..6260b3bebd2b 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
@@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,
 				      WORD_MASK, f->fs.nat_lip[3] |
 				      f->fs.nat_lip[2] << 8 |
 				      f->fs.nat_lip[1] << 16 |
-				      (u64)f->fs.nat_lip[0] << 25, 1);
+				      (u64)f->fs.nat_lip[0] << 24, 1);
 		}
 	}
 


Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)