netdev - Re: [PATCH 4.14] inet: use bigger hash table for IP ID generation (backported to 4.14)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANEQ_+JLe-nA=7T+_nQgfwJMe4OBz+8MRo1kR47adz4DPafw+g@mail.gmail.com>
Date:   Fri, 18 Jun 2021 13:29:23 +0300
From:   Amit Klein <aksecurity@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Eric Dumazet <edumazet@...gle.com>, Willy Tarreau <w@....eu>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 4.14] inet: use bigger hash table for IP ID generation
 (backported to 4.14)

I believe you ask about this one:
[ Upstream commit aa6dd211e4b1dde9d5dc25d699d35f789ae7eeba ]



On Fri, Jun 18, 2021 at 1:24 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Fri, Jun 18, 2021 at 02:51:22AM -0700, Amit Klein wrote:
> > Subject: inet: use bigger hash table for IP ID generation (backported to 4.14)
> > From: Amit Klein <aksecurity@...il.com>
> >
> > This is a backport to 4.14 of the following patch, originally
> > developed by Eric Dumazet.
> >
> > In commit 73f156a6e8c1 ("inetpeer: get rid of ip_id_count")
> > I used a very small hash table that could be abused
> > by patient attackers to reveal sensitive information.
> >
> > Switch to a dynamic sizing, depending on RAM size.
> >
> > Typical big hosts will now use 128x more storage (2 MB)
> > to get a similar increase in security and reduction
> > of hash collisions.
> >
> > As a bonus, use of alloc_large_system_hash() spreads
> > allocated memory among all NUMA nodes.
> >
> > Fixes: 73f156a6e8c1 ("inetpeer: get rid of ip_id_count")
> > Reported-by: Amit Klein <aksecurity@...il.com>
> > Cc: stable@...r.kernel.org
> > Cc: Eric Dumazet <edumazet@...gle.com>
> > Cc: Willy Tarreau <w@....eu>
> > ---
>
> What is the git commit id of this patch in Linus's tree?
>
> thanks,
>
> greg k-h