netdev - RE: [PATCH net-next 06/10] net: iosm: drop custom netdev(s) removing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d31c18cebf74ff29b5e388c4cd26361@intel.com>
Date:   Sun, 20 Jun 2021 15:42:41 +0000
From:   "Kumar, M Chetan" <m.chetan.kumar@...el.com>
To:     Sergey Ryazanov <ryazanov.s.a@...il.com>
CC:     Loic Poulain <loic.poulain@...aro.org>,
        Johannes Berg <johannes@...solutions.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        linuxwwan <linuxwwan@...el.com>
Subject: RE: [PATCH net-next 06/10] net: iosm: drop custom netdev(s) removing

Hi Sergey,

> On Tue, Jun 15, 2021 at 3:30 AM Sergey Ryazanov
> <ryazanov.s.a@...il.com> wrote:
> > Since the last commit, the WWAN core will remove all our network
> > interfaces for us at the time of the WWAN netdev ops unregistering.
> > Therefore, we can safely drop the custom code that cleaning the list
> > of created netdevs. Anyway it no longer removes any netdev, since all
> > netdevs were removed earlier in the wwan_unregister_ops() call.
> 
> Are you Ok with this change? I plan to submit a next version of the series. If
> you have any objections, I can address them in V2.

Changes looks fine.
 
> BTW, if IOSM modems have a default data channel, I can add a separate
> patch to the series to create a default network interface for IOSM if you tell
> me which link id is used for the default data channel.

Link id 1 is always associated as default data channel. 

Thanks,
Reviewed-by: M Chetan Kumar <m.chetan.kumar@...el.com>