netdev - Re: [RFCv3 00/19] x86/ftrace/bpf: Add batch support for direct/tracing attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQJFzGd-7C9Gn1XqhBWKY+fyr=4WooDSokkff+Ga-2U+nw@mail.gmail.com>
Date:   Sun, 20 Jun 2021 10:47:00 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     Jiri Olsa <jolsa@...hat.com>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andriin@...com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>, Daniel Xu <dxu@...uu.xyz>,
        Viktor Malik <vmalik@...hat.com>
Subject: Re: [RFCv3 00/19] x86/ftrace/bpf: Add batch support for
 direct/tracing attach

On Sun, Jun 20, 2021 at 9:57 AM Yonghong Song <yhs@...com> wrote:
> >
> > ah right, should have checked it.. so how about we change
> > trampoline code to store ip in ctx-8 and make bpf_get_func_ip(ctx)
> > to return [ctx-8]
>
> This should work. Thanks!

+1
and pls make it always inline into single LDX insn in the verifier.
For both mass attach and normal fentry/fexit.