[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210621141027.GJ1861@kadam>
Date: Mon, 21 Jun 2021 17:10:27 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Coiby Xu <coiby.xu@...il.com>
Cc: linux-staging@...ts.linux.dev, netdev@...r.kernel.org,
Benjamin Poirier <benjamin.poirier@...il.com>,
Shung-Hsi Yu <shung-hsi.yu@...e.com>,
Manish Chopra <manishc@...vell.com>,
"supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER"
<GR-Linux-NIC-Dev@...vell.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [RFC 01/19] staging: qlge: fix incorrect truesize accounting
On Mon, Jun 21, 2021 at 09:48:44PM +0800, Coiby Xu wrote:
> Commit 7c734359d3504c869132166d159c7f0649f0ab34 ("qlge: Size RX buffers
> based on MTU") introduced page_chunk structure. We should add
> qdev->lbq_buf_size to skb->truesize after __skb_fill_page_desc.
>
Add a Fixes tag.
The runtime impact of this is just that ethtool will report things
incorrectly, right? It's not 100% from the commit message. Could you
please edit the commit message so that an ignoramous like myself can
understand it?
Why is this an RFC instead of just a normal patch which we can apply?
regards,
dan carpenter
Powered by blists - more mailing lists