netdev - Re: [PATCH net-next] nfp: flower-ct: check for error in nfp_fl_ct_offload_nft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94d89b59-fe5b-d959-e2f0-9e42ebf73636@corigine.com>
Date:   Mon, 21 Jun 2021 07:15:08 +0200
From:   Louis Peens <louis.peens@...igine.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Simon Horman <simon.horman@...igine.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Yinjun Zhang <yinjun.zhang@...igine.com>,
        oss-drivers@...igine.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] nfp: flower-ct: check for error in
 nfp_fl_ct_offload_nft_flow()



On 2021/06/19 15:53, Dan Carpenter wrote:
> The nfp_fl_ct_add_flow() function can fail so we need to check for
> failure.
> 
> Fixes: 95255017e0a8 ("nfp: flower-ct: add nft flows to nft list")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
Ah, of course, thank you.
Reviewed-by: Louis Peens <louis.peens@...igine.com>
> ---
>  drivers/net/ethernet/netronome/nfp/flower/conntrack.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/flower/conntrack.c b/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
> index 9ea77bb3b69c..273d529d43c2 100644
> --- a/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
> +++ b/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
> @@ -1067,6 +1067,8 @@ nfp_fl_ct_offload_nft_flow(struct nfp_fl_ct_zone_entry *zt, struct flow_cls_offl
>  						    nfp_ct_map_params);
>  		if (!ct_map_ent) {
>  			ct_entry = nfp_fl_ct_add_flow(zt, NULL, flow, true, extack);
> +			if (IS_ERR(ct_entry))
> +				return PTR_ERR(ct_entry);
>  			ct_entry->type = CT_TYPE_NFT;
>  			list_add(&ct_entry->list_node, &zt->nft_flows_list);
>  			zt->nft_flows_count++;
>