netdev - Re: [PATCH] can: j1939: prevent allocation of j1939 filter for optlen = 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210621074735.mnok4c3rr7qwparu@pengutronix.de>
Date:   Mon, 21 Jun 2021 09:47:35 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Norbert Slusarek <nslusarek@....net>
Cc:     netdev@...r.kernel.org, ore@...gutronix.de, socketcan@...tkopp.net,
        davem@...emloft.net, kuba@...nel.org, linux-can@...r.kernel.org,
        kernel@...gutronix.de
Subject: Re: [PATCH] can: j1939: prevent allocation of j1939 filter for
 optlen = 0

On 20.06.2021 14:38:42, Norbert Slusarek wrote:
> If optval != NULL and optlen = 0 are specified for SO_J1939_FILTER in
> j1939_sk_setsockopt(), memdup_sockptr() will return ZERO_PTR for 0 size
> allocation. The new filter will be mistakenly assigned ZERO_PTR.
> This patch checks for optlen != 0 and filter will be assigned NULL
> in case of optlen = 0.
> 
> Fixes: a7b75c5a8c41 ("net: pass a sockptr_t into ->setsockopt")
> Signed-off-by: Norbert Slusarek <nslusarek@....net>

The problem was in the initial commit, too. Changed Fixes tags
accordingly to:

| Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")

applied to linux-can/testing

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)