netdev - Re: [PATCH] net: tun: fix tun_xdp_one() for IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c591ba57b673649736f37d64f0e5ea8973e85d86.camel@infradead.org>
Date:   Tue, 22 Jun 2021 12:36:01 +0100
From:   David Woodhouse <dwmw2@...radead.org>
To:     Jason Wang <jasowang@...hat.com>, netdev <netdev@...r.kernel.org>
Cc:     Eugenio Pérez <eperezma@...hat.com>
Subject: Re: [PATCH] net: tun: fix tun_xdp_one() for IFF_TUN mode

On Tue, 2021-06-22 at 15:51 +0800, Jason Wang wrote:
> > @@ -2388,14 +2406,18 @@ static int tun_xdp_one(struct tun_struct *tun,
> >           skb_reserve(skb, xdp->data - xdp->data_hard_start);
> >           skb_put(skb, xdp->data_end - xdp->data);
> >    
> > -       if (virtio_net_hdr_to_skb(skb, gso, tun_is_little_endian(tun))) {
> > +       if (!gso)
> > +               skb_reset_mac_header(skb);
> > +       else if (virtio_net_hdr_to_skb(skb, gso, tun_is_little_endian(tun))) {
> >                   atomic_long_inc(&tun->rx_frame_errors);
> >                   kfree_skb(skb);
> 
> 
> This should work as well.

Actually there's no need for the skb_reset_mac_header() as that's going
to happen anyway just a few lines down — either from eth_type_trans()
or explicitly in the IFF_TUN code path that I added in my first patch.

I also stripped out a lot more code from vhost_net_build_xdp() in the
!sock_hlen case where it was pointless.

https://git.infradead.org/users/dwmw2/linux.git/shortlog/vhost-net

I'll repost the whole series after I take look at whether I can get it
to work without *either* side doing the vnet header, and add a test
case based on my userspace code in 
https://gitlab.com/openconnect/openconnect/-/blob/vhost/vhost.c

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5174 bytes)