netdev - Re: [PATCH net-next v2 03/10] wwan: core: require WWAN netdev setup callback existence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZdPi-Smy7ygQeYTiEgWdXJ8=MOMGAUcA6F94r_qystK8_HCw@mail.gmail.com>
Date:   Tue, 22 Jun 2021 15:47:58 +0200
From:   Loic Poulain <loic.poulain@...aro.org>
To:     Sergey Ryazanov <ryazanov.s.a@...il.com>
Cc:     Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 03/10] wwan: core: require WWAN netdev setup
 callback existence

On Tue, 22 Jun 2021 at 00:51, Sergey Ryazanov <ryazanov.s.a@...il.com> wrote:
>
> The setup callback will be unconditionally passed to the
> alloc_netdev_mqs(), where the NULL pointer dereference will cause the
> kernel panic. So refuse to register WWAN netdev ops with warning
> generation if the setup callback is not provided.
>
> Signed-off-by: Sergey Ryazanov <ryazanov.s.a@...il.com>

Reviewed-by: Loic Poulain <loic.poulain@...aro.org>