netdev - Re: [PATCH net-next v2 05/10] wwan: core: remove all netdevs on ops unregistering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Jun 2021 15:50:29 +0200
From:   Loic Poulain <loic.poulain@...aro.org>
To:     Sergey Ryazanov <ryazanov.s.a@...il.com>
Cc:     Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 05/10] wwan: core: remove all netdevs on ops unregistering

On Tue, 22 Jun 2021 at 00:51, Sergey Ryazanov <ryazanov.s.a@...il.com> wrote:
>
> We use the ops owner module hold to protect against ops memory
> disappearing. But this approach does not protect us from a driver that
> unregisters ops but forgets to remove netdev(s) that were created using
> this ops. In such case, we are left with netdev(s), which can not be
> removed since ops is gone. Moreover, batch netdevs removing on
> deinitialization is a desireable option for WWAN drivers as it is a
> quite common task.
>
> Implement deletion of all created links on WWAN netdev ops unregistering
> in the same way that RTNL removes all links on RTNL ops unregistering.
> Simply remove all child netdevs of a device whose WWAN netdev ops is
> unregistering. This way we protecting the kernel from buggy drivers and
> make it easier to write a driver deinitialization code.
>
> Signed-off-by: Sergey Ryazanov <ryazanov.s.a@...il.com>

Reviewed-by: Loic Poulain <loic.poulain@...aro.org>