netdev - Re: [PATCH iproute2-next] devlink: Fix link errors on some systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <495243ae-a3c5-72b8-b76e-bc71baf57c84@nvidia.com>
Date:   Tue, 22 Jun 2021 08:43:53 +0300
From:   Roi Dayan <roid@...dia.com>
To:     <netdev@...r.kernel.org>
CC:     David Ahern <dsahern@...il.com>,
        Dmytro Linkin <dlinkin@...dia.com>,
        "Jiri Pirko" <jiri@...dia.com>
Subject: Re: [PATCH iproute2-next] devlink: Fix link errors on some systems

+jiri

On 2021-06-22 8:42 AM, Roi Dayan wrote:
> On some systems we fail to link because of missing math lib.
> add -lm to devlink.
> 
>      LINK     devlink
> ../lib/libutil.a(utils_math.o): In function `get_rate':
> utils_math.c:(.text+0xcc): undefined reference to `floor'
> ../lib/libutil.a(utils_math.o): In function `get_size':
> utils_math.c:(.text+0x384): undefined reference to `floor'
> collect2: error: ld returned 1 exit status
> make[1]: *** [Makefile:16: devlink] Error 1
> make: *** [Makefile:64: all] Error 2
> 
> Fixes: 6c70aca76ef2 ("devlink: Add port func rate support")
> Signed-off-by: Roi Dayan <roid@...dia.com>
> ---
>   devlink/Makefile | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/devlink/Makefile b/devlink/Makefile
> index d540feb3c012..d37a4b4d0241 100644
> --- a/devlink/Makefile
> +++ b/devlink/Makefile
> @@ -7,6 +7,7 @@ ifeq ($(HAVE_MNL),y)
>   
>   DEVLINKOBJ = devlink.o mnlg.o
>   TARGETS += devlink
> +LDLIBS += -lm
>   
>   endif
>   
>