netdev - Re: [PATCH net-next 0/7] ethtool: Module EEPROM API improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210622231030.fmknwontiqirdbw7@lion.mk-sys.cz>
Date:   Wed, 23 Jun 2021 01:10:30 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org,
        davem@...emloft.net, andrew@...n.ch, vladyslavt@...dia.com,
        moshe@...dia.com, mlxsw@...dia.com,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next 0/7] ethtool: Module EEPROM API improvements

On Tue, Jun 22, 2021 at 09:30:05AM -0700, Jakub Kicinski wrote:
> On Tue, 22 Jun 2021 09:50:45 +0300 Ido Schimmel wrote:
> > From: Ido Schimmel <idosch@...dia.com>
> > 
> > This patchset contains various improvements to recently introduced
> > module EEPROM netlink API. Noticed these while adding module EEPROM
> > write support.
> 
> Scary that 3/7 was not generating a warning.

Actually, it's not as scary as it seems. If an array variable is
declared with fixed size and then defined and initialized with just
"[]", the number of elements is still taken from the declaration, not
from the maximum initializer index. So there was nothing to worry about,
we just had a partially initialized array with extra elements zero
initialized.

Michal