netdev - Re: [PATCH net] xfrm: Fix xfrm offload fallback fail case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210623064654.GG40979@gauss3.secunet.de>
Date:   Wed, 23 Jun 2021 08:46:54 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Ayush Sawal <ayush.sawal@...lsio.com>
CC:     <netdev@...r.kernel.org>, <jarod@...hat.com>,
        <davem@...emloft.net>, <kuba@...nel.org>, <secdev@...lsio.com>
Subject: Re: [PATCH net] xfrm: Fix xfrm offload fallback fail case

On Tue, Jun 22, 2021 at 09:25:31AM +0530, Ayush Sawal wrote:
> In case of xfrm offload, if xdo_dev_state_add() of driver returns
> -EOPNOTSUPP, xfrm offload fallback is failed.
> In xfrm state_add() both xso->dev and xso->real_dev are initialized to
> dev and when err(-EOPNOTSUPP) is returned only xso->dev is set to null.
> 
> So in this scenario the condition in func validate_xmit_xfrm(),
> if ((x->xso.dev != dev) && (x->xso.real_dev == dev))
>                 return skb;
> returns true, due to which skb is returned without calling esp_xmit()
> below which has fallback code. Hence the CRYPTO_FALLBACK is failing.
> 
> So fixing this with by keeping x->xso.real_dev as NULL when err is
> returned in func xfrm_dev_state_add().
> 
> Fixes: bdfd2d1fa79a ("bonding/xfrm: use real_dev instead of slave_dev")
> Signed-off-by: Ayush Sawal <ayush.sawal@...lsio.com>

Applied, thanks Ayush!