netdev - Re: [PATCH] net: bridge: remove redundant return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e8df63b4-b16b-c3ed-3991-508c5840cf8d@gmail.com>
Date:   Wed, 23 Jun 2021 12:51:52 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     13145886936@....com, roopa@...dia.com, nikolay@...dia.com,
        davem@...emloft.net, kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        gushengxian <gushengxian@...ong.com>
Subject: Re: [PATCH] net: bridge: remove redundant return



On 6/23/21 2:53 AM, 13145886936@....com wrote:
> From: gushengxian <gushengxian@...ong.com>
> 
> Return statements are not needed in Void function.

Maybe, but this just works.

I see your patch as a matter of taste.


> 
> Signed-off-by: gushengxian <gushengxian@...ong.com>
> ---
>  net/bridge/br_netlink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index 8642e56059fb..b70075939721 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -619,7 +619,7 @@ void br_ifinfo_notify(int event, const struct net_bridge *br,
>  {
>  	u32 filter = RTEXT_FILTER_BRVLAN_COMPRESSED;
>  
> -	return br_info_notify(event, br, port, filter);
> +	br_info_notify(event, br, port, filter);
>  }
>  
>  /*
> @@ -814,7 +814,7 @@ static const struct nla_policy br_port_policy[IFLA_BRPORT_MAX + 1] = {
>  	[IFLA_BRPORT_MODE]	= { .type = NLA_U8 },
>  	[IFLA_BRPORT_GUARD]	= { .type = NLA_U8 },
>  	[IFLA_BRPORT_PROTECT]	= { .type = NLA_U8 },
> -	[IFLA_BRPORT_FAST_LEAVE]= { .type = NLA_U8 },
> +	[IFLA_BRPORT_FAST_LEAVE] = { .type = NLA_U8 },

Useless noise.

>  	[IFLA_BRPORT_LEARNING]	= { .type = NLA_U8 },
>  	[IFLA_BRPORT_UNICAST_FLOOD] = { .type = NLA_U8 },
>  	[IFLA_BRPORT_PROXYARP]	= { .type = NLA_U8 },
>