netdev - Re: [PATCH net] ipv6: fix out-of-bound access in ip6_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0e59d780e1c979c2666e8bc77ce00249ac3e6e1.camel@redhat.com>
Date:   Thu, 24 Jun 2021 11:49:30 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Tom Herbert <tom@...bertland.com>
Subject: Re: [PATCH net] ipv6: fix out-of-bound access in ip6_parse_tlv()

On Wed, 2021-06-23 at 12:43 -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> First problem is that optlen is fetched without checking
> there is more than one byte to parse.
> 
> Fix this by taking care of IPV6_TLV_PAD1 before
> fetching optlen (under appropriate sanity checks against len)
> 
> Second problem is that IPV6_TLV_PADN checks of zero
> padding are performed before the check of remaining length.
> 
> Fixes: c1412fce7ecc ("net/ipv6/exthdrs.c: Strict PadN option checking")

Perhaps even:

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

for the first issue?

> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Tom Herbert <tom@...bertland.com>
> ---
> 
> Only compiled, I would appreciate a solid review of this patch before merging it, thanks !
> 
>  net/ipv6/exthdrs.c | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
> index 6f7da8f3e2e5849f917853984c69bf02a0f1e27c..007959d4d3748f1e21f83946024a9967d08b25b6 100644
> --- a/net/ipv6/exthdrs.c
> +++ b/net/ipv6/exthdrs.c
> @@ -135,18 +135,24 @@ static bool ip6_parse_tlv(const struct tlvtype_proc *procs,
>  	len -= 2;
>  
>  	while (len > 0) {
> -		int optlen = nh[off + 1] + 2;
> -		int i;
> +		int optlen, i;
>  
> -		switch (nh[off]) {
> -		case IPV6_TLV_PAD1:
> +		if (nh[off] == IPV6_TLV_PAD1) {
>  			optlen = 1;

It looks like the above assignment is not needed anymore.

Other than that LGTM,

Thanks!

Paolo