netdev - RE: [PATCH net 2/2] ptp: idt82p33: implement double dco time correction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS3PR01MB659335F4857D1FD1E8977C24BA079@OS3PR01MB6593.jpnprd01.prod.outlook.com>
Date:   Thu, 24 Jun 2021 14:40:52 +0000
From:   Min Li <min.li.xe@...esas.com>
To:     Richard Cochran <richardcochran@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net 2/2] ptp: idt82p33: implement double dco time
 correction


> -----Original Message-----
> From: Richard Cochran <richardcochran@...il.com>
> Sent: June 23, 2021 11:44 PM
> To: Min Li <min.li.xe@...esas.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net 2/2] ptp: idt82p33: implement double dco time
> correction
> 
> On Wed, Jun 23, 2021 at 10:46:25AM -0400, min.li.xe@...esas.com wrote:
> > +static int idt82p33_start_ddco(struct idt82p33_channel *channel, s32
> > +delta_ns) {
> > +	s32 current_ppm = channel->current_freq;
> > +	u32 duration_ms = MSEC_PER_SEC;
> 
> What happens if user space makes a new adjustment before this completes?
> 
> After all, some PTP profiles update the clock several times per second.
> 
> Thanks,
> Richard

Hi Richard

In that case, adjtime would simply return without doing anything as in

@@ -848,11 +914,15 @@ static int idt82p33_adjtime(struct ptp_clock_info *ptp, s64 delta_ns)
 	struct idt82p33 *idt82p33 = channel->idt82p33;
 	int err;
 
+	if (channel->ddco == true)
+		return 0;
+