netdev - Re: [PATCH net 2/7] Revert "ibmvnic: remove duplicate napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOhMmr6g4XhnhRdMxP-CZxpJ6A1F0b=Lr+1vGWEKYfEk9YCVzA@mail.gmail.com>
Date:   Thu, 24 Jun 2021 11:53:22 -0500
From:   Lijun Pan <lijunp213@...il.com>
To:     Johaan Smith <johaansmith74@...il.com>
Cc:     Sukadev Bhattiprolu <sukadev@...ux.ibm.com>,
        Networking <netdev@...r.kernel.org>,
        Dany Madden <drt@...ux.ibm.com>,
        Rick Lindsley <ricklind@...ux.ibm.com>,
        Brian King <brking@...ux.ibm.com>,
        Cristobal Forno <cforno12@...ux.ibm.com>,
        Abdul Haleem <abdhalee@...ibm.com>
Subject: Re: [PATCH net 2/7] Revert "ibmvnic: remove duplicate napi_schedule
 call in open function"

On Thu, Jun 24, 2021 at 2:05 AM Johaan Smith <johaansmith74@...il.com> wrote:
>
> On Wed, Jun 23, 2021 at 11:17 PM Sukadev Bhattiprolu
> <sukadev@...ux.ibm.com> wrote:
> >
> > From: Dany Madden <drt@...ux.ibm.com>
> >
> > This reverts commit 7c451f3ef676c805a4b77a743a01a5c21a250a73.
> >
> > When a vnic interface is taken down and then up, connectivity is not
> > restored. We bisected it to this commit. Reverting this commit until
> > we can fully investigate the issue/benefit of the change.
> >
>
> Sometimes git bisect may lead us to the false positives. Full investigation is
> always the best solution if it is not too hard.

Agreed.