netdev - Re: [PATCH v2 1/4] net: tun: fix tun_xdp_one() for IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ff25025b4c5e167c3176b4607191019e4f3729a.camel@infradead.org>
Date:   Thu, 24 Jun 2021 08:05:45 +0100
From:   David Woodhouse <dwmw2@...radead.org>
To:     Jason Wang <jasowang@...hat.com>, netdev@...r.kernel.org
Cc:     Eugenio Pérez <eperezma@...hat.com>
Subject: Re: [PATCH v2 1/4] net: tun: fix tun_xdp_one() for IFF_TUN mode

On Thu, 2021-06-24 at 14:18 +0800, Jason Wang wrote:
> 在 2021/6/23 下午9:52, David Woodhouse 写道:
> > On Wed, 2021-06-23 at 11:45 +0800, Jason Wang wrote:
> > > As replied in previous version, it would be better if we can unify
> > > similar logic in tun_get_user().
> > 
> > So that ends up looking something like this (incremental).
> > 
> > Note the '/* XXX: frags && */' part in tun_skb_set_protocol(), because
> > the 'frags &&' was there in tun_get_user() and it wasn't obvious to me
> > whether I should be lifting that out as a separate argument to
> > tun_skb_set_protocol() or if there's a better way.
> > 
> > Either way, in my judgement this is less suitable for a stable fix and
> > more appropriate for a follow-on cleanup. But I don't feel that
> > strongly; I'm more than happy for you to overrule me on that.
> > Especially if you fix the above XXX part while you're at it :)
> 
> 
> By simply adding a boolean "pull" in tun_skb_set_protocol()?

Sure; thanks. It's been a few years since I really played with skb
handling; I was half hoping for a simpler "you don't need to
because..." answer, but that works :)


Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5174 bytes)