netdev - Re: [PATCH net] net: lwtunnel: handle MTU calculation in forwading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f8dda3aa-6945-09d4-c36e-793b773b7b8e@novek.ru>
Date:   Fri, 25 Jun 2021 17:16:14 +0100
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
        Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] net: lwtunnel: handle MTU calculation in forwading

On 25.06.2021 16:57, Vadim Fedorenko wrote:
> Commit 14972cbd34ff ("net: lwtunnel: Handle fragmentation") moved
> fragmentation logic away from lwtunnel by carry encap headroom and
> use it in output MTU calculation. But the forwarding part was not
> covered and created difference in MTU for output and forwarding and
> further to silent drops on ipv4 forwarding path. Fix it by taking
> into account lwtunnel encap headroom.
> 
> The same commit also introduced difference in how to treat RTAX_MTU
> in IPv4 and IPv6 where latter explicitly removes lwtunnel encap
> headroom from route MTU. Make IPv4 version do the same.
> 
> Fixes: 14972cbd34ff ("net: lwtunnel: Handle fragmentation")
> Suggested-by: David Ahern <dsahern@...il.com>
> Signed-off-by: Vadim Fedorenko <vfedorenko@...ek.ru>
> ---
>   include/net/ip.h        | 10 ++++++----
>   include/net/ip6_route.h | 16 ++++++++++++----
>   net/ipv4/route.c        |  3 ++-
>   3 files changed, 20 insertions(+), 9 deletions(-)
> 

Please, ingore it, I was too fast, sorry. Will post v2 soon