netdev - RE: [PATCH net 1/2] ptp: idt82p33: optimize idt82p33

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Jun 2021 14:24:24 +0000
From:   Min Li <min.li.xe@...esas.com>
To:     Richard Cochran <richardcochran@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net 1/2] ptp: idt82p33: optimize idt82p33_adjtime

Hi Richard

How would you suggest to implement the change that make the new driver behavior optional?
There is no additional parameter in adjtime to let me do that.

Thanks

Min

> -----Original Message-----
> From: Richard Cochran <richardcochran@...il.com>
> Sent: June 24, 2021 12:20 PM
> To: Min Li <min.li.xe@...esas.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net 1/2] ptp: idt82p33: optimize idt82p33_adjtime
> 
> On Thu, Jun 24, 2021 at 02:38:46PM +0000, Min Li wrote:
> > I have tested this change with ptp4l for by setting step_window to 48
> > (assuming 16 packets per second) for both 8265.2/8275.1 and they
> performed well.
> 
> Both of these patches assume that user space has a special configuration
> that works together with the non-standard driver behavior.
> 
> For this reason, I suggest making the new driver behavior optional, with the
> default being the origin version that "just works".  In that way, the
> admin/user can choose the special configuration on purpose, and the
> default performance will not be degraded.
> 
> Thanks,
> Richard