netdev - Re: [PATCH net-next 1/2] net: sock: introduce sk_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 26 Jun 2021 08:19:27 +0800
From:   kernel test robot <lkp@...el.com>
To:     Alexander Aring <aahringo@...hat.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net, kuba@...nel.org
Subject: Re: [PATCH net-next 1/2] net: sock: introduce sk_error_report

Hi Alexander,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Alexander-Aring/net-sock-add-tracers-for-inet-socket-errors/20210626-031959
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 19938bafa7ae8fc0a4a2c1c1430abb1a04668da1
config: mips-randconfig-r035-20210622 (attached as .config)
compiler: mips64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/23e631bac02c834a4d4e560e317bf7907d874484
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alexander-Aring/net-sock-add-tracers-for-inet-socket-errors/20210626-031959
        git checkout 23e631bac02c834a4d4e560e317bf7907d874484
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   net/qrtr/qrtr.c: In function 'qrtr_reset_ports':
>> net/qrtr/qrtr.c:754:3: error: 'sk' undeclared (first use in this function); did you mean 's8'?
     754 |   sk.sk_error_report(&ipc->sk);
         |   ^~
         |   s8
   net/qrtr/qrtr.c:754:3: note: each undeclared identifier is reported only once for each function it appears in


vim +754 net/qrtr/qrtr.c

   743	
   744	/* Reset all non-control ports */
   745	static void qrtr_reset_ports(void)
   746	{
   747		struct qrtr_sock *ipc;
   748		unsigned long index;
   749	
   750		rcu_read_lock();
   751		xa_for_each_start(&qrtr_ports, index, ipc, 1) {
   752			sock_hold(&ipc->sk);
   753			ipc->sk.sk_err = ENETRESET;
 > 754			sk.sk_error_report(&ipc->sk);
   755			sock_put(&ipc->sk);
   756		}
   757		rcu_read_unlock();
   758	}
   759	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (25738 bytes)