netdev - [PATCH v2 net-next 0/8] Cleanup for the bridge replay helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210627115429.1084203-1-olteanv@gmail.com>
Date:   Sun, 27 Jun 2021 14:54:21 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Ido Schimmel <idosch@...sch.org>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: [PATCH v2 net-next 0/8] Cleanup for the bridge replay helpers

From: Vladimir Oltean <vladimir.oltean@....com>

This patch series brings some improvements to the logic added to the
bridge and DSA to handle LAG interfaces sandwiched between a bridge and
a DSA switch port.

        br0
        /  \
       /    \
     bond0  swp2
     /  \
    /    \
  swp0  swp1

In particular, it ensures that the switchdev object additions and
deletions are well balanced per physical port. This is important for
future work in the area of offloading local bridge FDB entries to
hardware in the context of DSA requesting a replay of those entries at
bridge join time (this will be submitted in a future patch series).
Due to some difficulty ensuring that the deletion of local FDB entries
pointing towards the bridge device itself is notified to switchdev in
time (before the switchdev port disconnects from the bridge), this is
potentially still not the final form in which the replay helpers will
exist. I'm thinking about moving from the pull mode (in which DSA
requests the replay) to a push mode (in which the bridge initiates the
replay). Nonetheless, these preliminary changes are needed either way.

The patch series also addresses some feedback from Nikolai which is long
overdue by now (sorry).

Switchdev driver maintainers were deliberately omitted due to the
trivial nature of the driver changes (just a function prototype).

Changes in v2:
- fix build issue in patch 4 (function prototype mismatch)
- move switchdev object unsync to the NETDEV_PRECHANGEUPPER code path

Vladimir Oltean (8):
  net: bridge: include the is_local bit in br_fdb_replay
  net: ocelot: delete call to br_fdb_replay
  net: switchdev: add a context void pointer to struct
    switchdev_notifier_info
  net: bridge: ignore switchdev events for LAG ports which didn't
    request replay
  net: bridge: constify variables in the replay helpers
  net: bridge: allow the switchdev replay functions to be called for
    deletion
  net: dsa: refactor the prechangeupper sanity checks into a dedicated
    function
  net: dsa: replay a deletion of switchdev objects for ports leaving a
    bridged LAG

 .../ethernet/freescale/dpaa2/dpaa2-switch.c   |   2 +-
 .../marvell/prestera/prestera_switchdev.c     |   6 +-
 .../mellanox/mlx5/core/en/rep/bridge.c        |   3 +
 .../mellanox/mlxsw/spectrum_switchdev.c       |   6 +-
 .../microchip/sparx5/sparx5_switchdev.c       |   2 +-
 drivers/net/ethernet/mscc/ocelot_net.c        |  29 +++--
 drivers/net/ethernet/ti/am65-cpsw-switchdev.c |   6 +-
 drivers/net/ethernet/ti/cpsw_switchdev.c      |   6 +-
 include/linux/if_bridge.h                     |  30 ++---
 include/net/switchdev.h                       |  13 ++-
 net/bridge/br_fdb.c                           |  23 ++--
 net/bridge/br_mdb.c                           |  23 ++--
 net/bridge/br_stp.c                           |   4 +-
 net/bridge/br_vlan.c                          |  15 ++-
 net/dsa/dsa_priv.h                            |   4 +
 net/dsa/port.c                                |  58 +++++++--
 net/dsa/slave.c                               | 110 +++++++++++++++---
 net/switchdev/switchdev.c                     |  25 ++--
 18 files changed, 267 insertions(+), 98 deletions(-)

-- 
2.25.1