netdev - Re: [PATCH net-next 3/7] net: switchdev: add a context void pointer to struct switchdev_notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30f7a2a2-5ac9-3c91-67e4-b4f624262ec9@gmail.com>
Date:   Sat, 26 Jun 2021 19:58:02 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Ido Schimmel <idosch@...sch.org>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 3/7] net: switchdev: add a context void pointer
 to struct switchdev_notifier_info



On 6/25/2021 11:53 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> In the case where the driver asks for a replay of a certain type of
> event (port object or attribute) for a bridge port that is a LAG, it may
> do so because this port has just joined the LAG.
> 
> But there might already be other switchdev ports in that LAG, and it is
> preferable that those preexisting switchdev ports do not act upon the
> replayed event.
> 
> The solution is to add a context to switchdev events, which is NULL most
> of the time (when the bridge layer initiates the call) but which can be
> set to a value controlled by the switchdev driver when a replay is
> requested. The driver can then check the context to figure out if all
> ports within the LAG should act upon the switchdev event, or just the
> ones that match the context.
> 
> We have to modify all switchdev_handle_* helper functions as well as the
> prototypes in the drivers that use these helpers too, because these
> helpers hide the underlying struct switchdev_notifier_info from us and
> there is no way to retrieve the context otherwise.
> 
> The context structure will be populated and used in later patches.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian