netdev - Re: [PATCH] net: sched: fix warning in tcindex_alloc_perfect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWtncQbhfkrBNCU3iMKYfYCvhKzxTwoo0WWtDKpKbMe3w@mail.gmail.com>
Date:   Sun, 27 Jun 2021 11:22:32 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Pavel Skripkin <paskripkin@...il.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        syzbot+1071ad60cd7df39fdadb@...kaller.appspotmail.com
Subject: Re: [PATCH] net: sched: fix warning in tcindex_alloc_perfect_hash

On Fri, Jun 25, 2021 at 1:23 PM Pavel Skripkin <paskripkin@...il.com> wrote:
>
> Syzbot reported warning in tcindex_alloc_perfect_hash. The problem
> was in too big cp->hash, which triggers warning in kmalloc. Since
> cp->hash comes from userspace, there is no need to warn if value
> is not correct
>
> Fixes: b9a24bb76bf6 ("net_sched: properly handle failure case of tcf_exts_init()")
> Reported-and-tested-by: syzbot+1071ad60cd7df39fdadb@...kaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@...il.com>

Looks reasonable.

Acked-by: Cong Wang <cong.wang@...edance.com>

Thanks.