netdev - Re: [PATCH net-next 6/7] net: bridge: allow the switchdev replay functions to be called for deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42b36391-a496-41f0-18bf-7427211c0117@gmail.com>
Date:   Sat, 26 Jun 2021 20:01:30 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Ido Schimmel <idosch@...sch.org>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 6/7] net: bridge: allow the switchdev replay
 functions to be called for deletion



On 6/25/2021 11:53 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> When a switchdev port leaves a LAG that is a bridge port, the switchdev
> objects and port attributes offloaded to that port are not removed:
> 
> ip link add br0 type bridge
> ip link add bond0 type bond mode 802.3ad
> ip link set swp0 master bond0
> ip link set bond0 master br0
> bridge vlan add dev bond0 vid 100
> ip link set swp0 nomaster
> 
> VLAN 100 will remain installed on swp0 despite it going into standalone
> mode, because as far as the bridge is concerned, nothing ever happened
> to its bridge port.
> 
> Let's extend the bridge vlan, fdb and mdb replay functions to take a
> 'bool adding' argument, and make DSA and ocelot call the replay
> functions with 'adding' as false from the switchdev unsync path, for the
> switch port that leaves the bridge.
> 
> Note that this patch in itself does not salvage anything, because in the
> current pull mode of operation, DSA still needs to call the replay
> helpers with adding=false. This will be done in another patch.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian