[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <0a1614c4-19b7-2665-8eb9-7df776fa4c13@iogearbox.net>
Date: Mon, 28 Jun 2021 16:33:10 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, netdev@...r.kernel.org,
bpf@...r.kernel.org
Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>,
Tony Nguyen <anthony.l.nguyen@...el.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Björn Töpel <bjorn@...nel.org>,
Magnus Karlsson <magnus.karlsson@...el.com>,
Jonathan Lemon <jonathan.lemon@...il.com>,
Alexei Starovoitov <ast@...nel.org>,
Jesper Dangaard Brouer <hawk@...nel.org>,
John Fastabend <john.fastabend@...il.com>,
Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
Krzysztof Kazimierczak <krzysztof.kazimierczak@...el.com>,
Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
Ong Boon Leong <boon.leong.ong@...el.com>,
intel-wired-lan@...ts.osuosl.org,
linux-stm32@...md-mailman.stormreply.com, maximmi@...dia.com
Subject: Re: [PATCH net v3] xdp, net: fix for construct skb by xdp inside xsk
zc rx
Hi Xuan,
On 6/28/21 1:46 PM, Xuan Zhuo wrote:
> When each driver supports xsk rx, if the received buff returns XDP_PASS
> after run xdp prog, it must construct skb based on xdp. This patch
> extracts this logic into a public function xdp_construct_skb().
>
> There is a bug in the original logic. When constructing skb, we should
> copy the meta information to skb and then use __skb_pull() to correct
> the data.
>
> Fixes: 0a714186d3c0f ("i40e: add AF_XDP zero-copy Rx support")
> Fixes: 2d4238f556972 ("ice: Add support for AF_XDP")
> Fixes: bba2556efad66 ("net: stmmac: Enable RX via AF_XDP zero-copy")
> Fixes: d0bcacd0a1309 ("ixgbe: add AF_XDP zero-copy Rx support")
> Signed-off-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
There was still an ongoing discussion on the v2 of your patch between
Maciej and Maxim (Cc). Before you submit a v3, please let the discussion
conclude first.
Thanks,
Daniel
Powered by blists - more mailing lists