netdev - RE: [PATCH net-next 2/5] ice: add support for auxiliary input/output pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcc626d6773745ae9ecee10dfaca1316@intel.com>
Date:   Mon, 28 Jun 2021 22:45:50 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Richard Cochran <richardcochran@...il.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "Machnikowski, Maciej" <maciej.machnikowski@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 2/5] ice: add support for auxiliary input/output
 pins



> -----Original Message-----
> From: Richard Cochran <richardcochran@...il.com>
> Sent: Saturday, June 26, 2021 7:03 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Cc: davem@...emloft.net; kuba@...nel.org; Machnikowski, Maciej
> <maciej.machnikowski@...el.com>; netdev@...r.kernel.org; Keller, Jacob E
> <jacob.e.keller@...el.com>
> Subject: Re: [PATCH net-next 2/5] ice: add support for auxiliary input/output pins
> 
> On Fri, Jun 25, 2021 at 11:57:30AM -0700, Tony Nguyen wrote:
> 
> > @@ -783,6 +1064,17 @@ static long ice_ptp_create_clock(struct ice_pf *pf)
> >  	info = &pf->ptp.info;
> >  	dev = ice_pf_to_dev(pf);
> >
> > +	/* Allocate memory for kernel pins interface */
> > +	if (info->n_pins) {
> > +		info->pin_config = devm_kcalloc(dev, info->n_pins,
> > +						sizeof(*info->pin_config),
> > +						GFP_KERNEL);
> > +		if (!info->pin_config) {
> > +			info->n_pins = 0;
> > +			return -ENOMEM;
> > +		}
> > +	}
> 
> How is this supposed to worK?
> 
> - If n_pins is non-zero, there must also be a ptp_caps.verify method,
>   but you don't provide one.
> 

Hmm. Yea, that's missing.

> - You allocate the pin_config, but you don't set the .name or .index fields.
> 

Ok

> Thanks,
> Richard
> 

Lets hold on this one until I can discuss with Maciej about what's missing here and what we need to add.

Thanks for the careful review, Richard!

Thanks,
Jake