netdev - Re: [PATCH] ptp: Add PTP_CLOCK_EXTTSUSR internal ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Jun 2021 16:30:56 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH] ptp: Add PTP_CLOCK_EXTTSUSR internal ptp_event

On Mon, Jun 28, 2021 at 11:46:11AM -0700, Jonathan Lemon wrote:
> This event differs from CLOCK_EXTTS in two ways:
> 
>  1) The caller provides the sec/nsec fields directly, instead of
>     needing to convert them from the timestamp field.

And that is useful?  how?
 
>  2) A 32 bit data field is attached to the event, which is returned
>     to userspace, which allows returning timestamped data information.
>     This may be used for things like returning the phase difference
>     between two time sources.

What two time sources?

What problem are you trying to solve?

As it stands, without any kind of rational at all, this patch gets a NAK.

Thanks,
Richard