netdev - Re: [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain RGMII interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADujJWXFFBUy9H3-w32uCYs_cJM5dBrWFzRg3x-Dq9+kki436g@mail.gmail.com>
Date:   Mon, 28 Jun 2021 21:12:41 -0400
From:   Kurt Cancemi <kurt@...architecture.com>
To:     Marek Behún <kabel@...nel.org>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain
 RGMII interface

I am using drivers/net/ethernet/freescale/dpaa. This is a T2080 soc.

The following is where I added a dev_info statement for "phy_if", it
correctly returned -> PHY_INTERFACE_MODE_RGMII_ID.
https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/freescale/fman/mac.c#L774

I will clarify things better, I am using an almost verbatim device
tree "arch/powerpc/boot/dts/fsl/t2080rdb.dts" the only changes I made
are the following:

Doesn't Work (RX and TX errors on every packet):
--- t2080rdb.dts    2021-06-28 21:08:06.571758700 -0400
+++ t2080rdb-doesnt_work.dts    2021-06-28 21:08:10.704915200 -0400
@@ -68,7 +68,7 @@

         ethernet@...00 {
             phy-handle = <&rgmii_phy1>;
-            phy-connection-type = "rgmii";
+            phy-connection-type = "rgmii-id";
         };

         ethernet@...00 {

Works (Your suggestion):
--- t2080rdb.dts    2021-06-28 21:08:06.571758700 -0400
+++ t2080rdb-works.dts    2021-06-28 21:09:49.415971900 -0400
@@ -68,7 +68,7 @@

         ethernet@...00 {
             phy-handle = <&rgmii_phy1>;
-            phy-connection-type = "rgmii";
+            phy-mode = "rgmii-id";
         };

         ethernet@...00 {

On Mon, Jun 28, 2021 at 8:23 PM Marek Behún <kabel@...nel.org> wrote:
>
> On Mon, 28 Jun 2021 19:09:49 -0400
> Kurt Cancemi <kurt@...architecture.com> wrote:
>
> > I’m sorry if I proposed this wrong (I am new to the kernel mailing list), I
> > acknowledge that this is probably not the way to fix the problem, I wanted
> > to discuss why my fix is necessary. In the cover email I explained that I
> > used (in the device tree) “rgmii-id” for the “phy-connection-type” and the
> > DPAA memac correctly reports that the PHY type is “PHY_INTERFACE_MODE_RGMII_ID”
> > but without my patch the RX and TX delay flags are not set on the
> > underlying Marvell PHY and I receive RX and TX errors on every network
> > request. Maybe there is some type of incompatibility between the Freescale
> > DPAA1 Ethernet driver and the Marvell PHY?
>
> Which driver again?
>   drivers/net/ethernet/freescale/dpaa
> or
>   drivers/net/ethernet/freescale/dpaa2
> ?