netdev - RE: [PATCH net-next 2/5] ice: add support for auxiliary input/output pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e60e10f4d5c43b78c9a46834a836cc1@intel.com>
Date:   Tue, 29 Jun 2021 19:32:09 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Richard Cochran <richardcochran@...il.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "Machnikowski, Maciej" <maciej.machnikowski@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 2/5] ice: add support for auxiliary input/output
 pins



> -----Original Message-----
> From: Keller, Jacob E <jacob.e.keller@...el.com>
> Sent: Tuesday, June 29, 2021 12:29 PM
> To: Keller, Jacob E <jacob.e.keller@...el.com>; Richard Cochran
> <richardcochran@...il.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>
> Cc: davem@...emloft.net; kuba@...nel.org; Machnikowski, Maciej
> <maciej.machnikowski@...el.com>; netdev@...r.kernel.org
> Subject: RE: [PATCH net-next 2/5] ice: add support for auxiliary input/output pins
> 
> 
> 
> > -----Original Message-----
> > From: Keller, Jacob E <jacob.e.keller@...el.com>
> > Sent: Monday, June 28, 2021 3:46 PM
> > To: Richard Cochran <richardcochran@...il.com>; Nguyen, Anthony L
> > <anthony.l.nguyen@...el.com>
> > Cc: davem@...emloft.net; kuba@...nel.org; Machnikowski, Maciej
> > <maciej.machnikowski@...el.com>; netdev@...r.kernel.org
> > Subject: RE: [PATCH net-next 2/5] ice: add support for auxiliary input/output
> pins
> >
> >
> >
> > > -----Original Message-----
> > > From: Richard Cochran <richardcochran@...il.com>
> > > Sent: Saturday, June 26, 2021 7:03 AM
> > > To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> > > Cc: davem@...emloft.net; kuba@...nel.org; Machnikowski, Maciej
> > > <maciej.machnikowski@...el.com>; netdev@...r.kernel.org; Keller, Jacob E
> > > <jacob.e.keller@...el.com>
> > > Subject: Re: [PATCH net-next 2/5] ice: add support for auxiliary input/output
> > pins
> > >
> > > On Fri, Jun 25, 2021 at 11:57:30AM -0700, Tony Nguyen wrote:
> > >
> > > > @@ -783,6 +1064,17 @@ static long ice_ptp_create_clock(struct ice_pf *pf)
> > > >  	info = &pf->ptp.info;
> > > >  	dev = ice_pf_to_dev(pf);
> > > >
> > > > +	/* Allocate memory for kernel pins interface */
> > > > +	if (info->n_pins) {
> > > > +		info->pin_config = devm_kcalloc(dev, info->n_pins,
> > > > +						sizeof(*info->pin_config),
> > > > +						GFP_KERNEL);
> > > > +		if (!info->pin_config) {
> > > > +			info->n_pins = 0;
> > > > +			return -ENOMEM;
> > > > +		}
> > > > +	}
> > >
> > > How is this supposed to worK?
> > >
> > > - If n_pins is non-zero, there must also be a ptp_caps.verify method,
> > >   but you don't provide one.
> > >
> >
> > Hmm. Yea, that's missing.
> 
> Ok, turns out this is only intended for a later patch that adds support for some
> pins on E810-T devices, but that work wasn't done yet. We need to split this up
> more, but currently we never set info->n_pins > 0 so this is effectively dead code.
> 
> For now, we need to drop this patch from the series.

Looks like this was pulled already. It shouldn't cause an issue because n_pins is never set to non-zero so it's really just dead code until we can complete the E810-T work.

Thanks,
Jake