netdev - Re: [PATCH net] net: ipv6: fix return value of ip6_skb_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a6226bd6-8e19-3119-cbf7-93d1d3c642a3@gmail.com>
Date:   Mon, 28 Jun 2021 21:20:17 -0600
From:   David Ahern <dsahern@...il.com>
To:     Vadim Fedorenko <vfedorenko@...ek.ru>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] net: ipv6: fix return value of ip6_skb_dst_mtu

On 6/28/21 3:54 PM, Vadim Fedorenko wrote:
> Commit 628a5c561890 ("[INET]: Add IP(V6)_PMTUDISC_RPOBE") introduced
> ip6_skb_dst_mtu with return value of signed int which is inconsistent
> with actually returned values. Also 2 users of this function actually
> assign its value to unsigned int variable and only __xfrm6_output
> assigns result of this function to signed variable but actually uses
> as unsigned in further comparisons and calls. Change this function
> to return unsigned int value.
> 
> Fixes: 628a5c561890 ("[INET]: Add IP(V6)_PMTUDISC_RPOBE")
> Signed-off-by: Vadim Fedorenko <vfedorenko@...ek.ru>
> ---
>  include/net/ip6_route.h | 2 +-
>  net/ipv6/xfrm6_output.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>