netdev - Re: [PATCH net-next 06/10] net: iosm: drop custom netdev(s) removing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <32682574-cafa-731a-e453-83b266b6df67@intel.com>
Date:   Wed, 30 Jun 2021 10:41:45 +0530
From:   "Kumar, M Chetan" <m.chetan.kumar@...el.com>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     Sergey Ryazanov <ryazanov.s.a@...il.com>,
        Johannes Berg <johannes@...solutions.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        linuxwwan <linuxwwan@...el.com>
Subject: Re: [PATCH net-next 06/10] net: iosm: drop custom netdev(s) removing

Hi Loic,

On 6/29/2021 8:59 PM, Loic Poulain wrote:
> Hi Chetan,
> 
> On Tue, 29 Jun 2021 at 16:56, Kumar, M Chetan <m.chetan.kumar@...el.com> wrote:
>>
>> Hi Loic,
>>
>> On 6/29/2021 7:44 PM, Loic Poulain wrote:
>>
>>>>> BTW, if IOSM modems have a default data channel, I can add a separate
>>>>> patch to the series to create a default network interface for IOSM if you tell
>>>>> me which link id is used for the default data channel.
>>>>
>>>> Link id 1 is always associated as default data channel.
>>>
>>> Quick question, Isn't your driver use MBIM session IDs? with
>>> session-ID 0 as the default one?
>>
>> Link Id from 1 to 8 are treated as valid link ids. These ids are
>> decremented by 1 to match session id.
>>
>> In this case link id 1 would be mapped to session id 0. So have
>> requested link id 1 to be set as default data channel.
> 
> Oh ok, but why? it seems quite confusing, that means a user creating a
> MBIM session 0 has to create a link with ID 1?
> It seems to be quite specific to your driver, can't you simply handle
> ID 0 from user? to keep aligned with other drivers.

Thought link id 0 is not a valid id so had considered it from 1 :(

Sure, We will correct it to be intact with other drivers.

Regards,
Chetan