netdev - Re: [PATCH 1/1] ibmvnic: retry reset if there are no other resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22a8ba0ae3f41f484de48a92171538d1@imap.linux.ibm.com>
Date:   Wed, 30 Jun 2021 12:04:59 -0700
From:   Dany Madden <drt@...ux.ibm.com>
To:     Sukadev Bhattiprolu <sukadev@...ux.ibm.com>
Cc:     netdev@...r.kernel.org, brking@...ux.vnet.ibm.com,
        ricklind@...ux.vnet.ibm.com
Subject: Re: [PATCH 1/1] ibmvnic: retry reset if there are no other resets

On 2021-06-30 11:36, Sukadev Bhattiprolu wrote:
> Normally, if a reset fails due to failover or other communication error
> there is another reset (eg: FAILOVER) in the queue and we would process
> that reset. But if we are unable to communicate with PHYP or VIOS after
> H_FREE_CRQ, there would be no other resets in the queue and the adapter
> would be in an undefined state even though it was in the OPEN state
> earlier. While starting the reset we set the carrier to off state so
> we won't even get the timeout resets.
> 
> If the last queued reset fails, retry it as a hard reset (after the
> usual 60 second settling time).
> 
> Signed-off-by: Sukadev Bhattiprolu <sukadev@...ux.ibm.com>

Reviewed-by: Dany Madden <drt@...ux.ibm.com>

> ---