netdev - Re: [PATCH net-next] net: dsa: return -EOPNOTSUPP when driver does not implement .port_lag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <162516480406.21656.16205874493520440945.git-patchwork-notify@kernel.org>
Date:   Thu, 01 Jul 2021 18:40:04 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     kuba@...nel.org, davem@...emloft.net, netdev@...r.kernel.org,
        f.fainelli@...il.com, andrew@...n.ch, vivien.didelot@...il.com
Subject: Re: [PATCH net-next] net: dsa: return -EOPNOTSUPP when driver does not
 implement .port_lag_join

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 29 Jun 2021 23:32:15 +0300 you wrote:
> The DSA core has a layered structure, and even though we end up
> returning 0 (success) to user space when setting a bonding/team upper
> that can't be offloaded, some parts of the framework actually need to
> know that we couldn't offload that.
> 
> For example, if dsa_switch_lag_join returns 0 as it currently does,
> dsa_port_lag_join has no way to tell a successful offload from a
> software fallback, and it will call dsa_port_bridge_join afterwards.
> Then we'll think we're offloading the bridge master of the LAG, when in
> fact we're not even offloading the LAG. In turn, this will make us set
> skb->offload_fwd_mark = true, which is incorrect and the bridge doesn't
> like it.
> 
> [...]

Here is the summary with links:
  - [net-next] net: dsa: return -EOPNOTSUPP when driver does not implement .port_lag_join
    https://git.kernel.org/netdev/net-next/c/b71d09871566

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html