netdev - Re: [RFC net-next 2/2] net: ipv4: Consolidate ipv4_mtu and ip_dst_mtu_maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e6bea71-d1f4-0b4a-2cba-6e48d483ed5f@novek.ru>
Date:   Thu, 1 Jul 2021 10:14:01 +0100
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     David Ahern <dsahern@...il.com>, David Ahern <dsahern@...nel.org>,
        netdev@...r.kernel.org
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        "David S. Miller" <davem@...emloft.net>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Florian Westphal <fw@...len.de>
Subject: Re: [RFC net-next 2/2] net: ipv4: Consolidate ipv4_mtu and
 ip_dst_mtu_maybe_forward

On 01.07.2021 02:40, David Ahern wrote:
> On 6/30/21 7:17 PM, Vadim Fedorenko wrote:
>> Consolidate IPv4 MTU code the same way it is done in IPv6 to have code
>> aligned in both address families
>>
>> Signed-off-by: Vadim Fedorenko <vfedorenko@...ek.ru>
>> ---
>>   include/net/ip.h | 22 ++++++++++++++++++----
>>   net/ipv4/route.c | 21 +--------------------
>>   2 files changed, 19 insertions(+), 24 deletions(-)
>>
>> diff --git a/include/net/ip.h b/include/net/ip.h
>> index d9683bef8684..ed261f2a40ac 100644
>> --- a/include/net/ip.h
>> +++ b/include/net/ip.h
>> @@ -436,18 +436,32 @@ static inline bool ip_sk_ignore_df(const struct sock *sk)
>>   static inline unsigned int ip_dst_mtu_maybe_forward(const struct dst_entry *dst,
>>   						    bool forwarding)
>>   {
>> +	const struct rtable *rt = (const struct rtable *)dst;
> 
> I realize this a code move from ipv4_mtu, but please use container_of
> here; I have been removing the typecasts as code is changed.
> 
No problem, I will change in next iteration