netdev - Re: [PATCH net-next v2 0/6] ethtool: add standard FEC statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210701084237.4b27bea3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 1 Jul 2021 08:42:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "huangguangbin (A)" <huangguangbin2@...wei.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <michael.chan@...adcom.com>, <saeedm@...dia.com>,
        <leon@...nel.org>, <ecree.xilinx@...il.com>,
        <habetsm.xilinx@...il.com>, <f.fainelli@...il.com>,
        <andrew@...n.ch>, <mkubecek@...e.cz>, <ariela@...dia.com>
Subject: Re: [PATCH net-next v2 0/6] ethtool: add standard FEC statistics

On Thu, 1 Jul 2021 20:18:15 +0800 huangguangbin (A) wrote:
> On 2021/5/19 1:30, Jakub Kicinski wrote:
> > On Tue, 18 May 2021 14:48:13 +0800 huangguangbin (A) wrote:  
> >> Hi, I have a doubt that why active FEC encoding is None here?
> >> Should it actually be BaseR or RS if FEC statistics are reported?  
> > 
> > Hi! Good point. The values in the example are collected from a netdevsim
> > based mock up which I used for testing the interface, not real hardware.
> > In reality seeing None and corrected/uncorrectable blocks is not valid.
> > That said please keep in mind that the statistics should not be reset
> > when settings are changed, so OFF + stats may happen.
> > .
> >   
> Hi, Jakub, I have another question of per-lane counters.
> If speed is changed, do the lane number of FEC statistics need to follow the change?
> For examples, change speed from 200Gbps to 50Gbps, the actual used lane number is
> changed from 4 to 2, in this case, how many lanes are needed to display FEC statistic?
> Still 4 lanes or 2 lanes?

I'd always report counters for max number of lanes supported by the HW.
Much like you'd do if you were directly exposing the register values,
the registers are still there in HW.