lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 5 Jul 2021 13:25:21 -0400
From:   Jamal Hadi Salim <>
To:     Phil Sutter <>,
        Stephen Hemminger <>,
Subject: Re: [iproute PATCH] tc: u32: Fix key folding in sample option

On 2021-07-05 10:17 a.m., Phil Sutter wrote:
> Hi,
> On Tue, Feb 02, 2021 at 07:30:51PM +0100, Phil Sutter wrote:
>> In between Linux kernel 2.4 and 2.6, key folding for hash tables changed
>> in kernel space. When iproute2 dropped support for the older algorithm,
>> the wrong code was removed and kernel 2.4 folding method remained in
>> place. To get things functional for recent kernels again, restoring the
>> old code alone was not sufficient - additional byteorder fixes were
>> needed.
>> While being at it, make use of ffs() and thereby align the code with how
>> kernel determines the shift width.
>> Fixes: 267480f55383c ("Backout the 2.4 utsname hash patch.")
>> Signed-off-by: Phil Sutter <>
> Seems this patch fell off the table? Or was there an objection I missed?

None i am aware of. I did ACK the patch.


Powered by blists - more mailing lists